fix!: Remove unused fields verifyingContract & salt from EIP712 domain separator #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Salt: "0", | ||
| Name: "Kava Cosmos", | ||
| Version: "1.0.0", | ||
| ChainId: math.NewHexOrDecimal256(int64(chainID)), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
drklee3
changed the title
drklee3
changed the title
drklee3
changed the title
somehow deleted this on accident
drklee3
commented
Sep 10, 2024
| { "name": "chainId", "type": "uint256" }, | ||
| { "name": "verifyingContract", "type": "string" }, | ||
| { "name": "salt", "type": "string" } | ||
| { "name": "chainId", "type": "uint256" } |
There was a problem hiding this comment.
expected EIP712Domain has the two fields removed now
1 task
DracoLi
approved these changes
Sep 19, 2024
pirtleshell
pushed a commit
that referenced
this pull request
Oct 25, 2024
…n separator (#75) verifyingContract field is validated by MetaMask to be an address, but was expected to be a string. This field is unused so it is removed.
pirtleshell
pushed a commit
that referenced
this pull request
Oct 25, 2024
…n separator (#75) verifyingContract field is validated by MetaMask to be an address, but was expected to be a string. This field is unused so it is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change as it changes the expected fields in the EIP712 data that is signed.
verifyingContractfield to empty string to exclude itSaltis also set to empty as it is unusedverifyingContractandSaltas it is unused now the fields are omitted.To be backported tono longer to be included in a standalone upgradekava/release/v0.27.xrelease branch